Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query filter may break because of Interactivity API changes. #490

Closed
StevenDufresne opened this issue Oct 25, 2023 · 2 comments
Closed

Query filter may break because of Interactivity API changes. #490

StevenDufresne opened this issue Oct 25, 2023 · 2 comments
Assignees
Labels
[Block] Query Filter [Status] Blocked Can't move forward until something outside the issue/PR is resolved

Comments

@StevenDufresne
Copy link
Contributor

We use the interactivity API for the query block. The store parameters are likely to change.

The way we create the state will no longer work should the proposal go through.

Instead of creating the store like:

store( {
	actions: {
		wporg: {}
} );

You will need to pass the namespace

store( "myNamespace", {
	actions: {}
)

The directive format should also be updated.

@ryelle
Copy link
Contributor

ryelle commented Jan 10, 2024

Looks like this will happen when we update above GB 17.2 (current is 17.4.1). There are migration instructions in this changelog discussion.

Currently wporg is stuck on 16.8.1 due to a conflict with Blocks Everywhere.

@ryelle
Copy link
Contributor

ryelle commented Mar 11, 2024

Fixed with #561 & #563.

@ryelle ryelle closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Filter [Status] Blocked Can't move forward until something outside the issue/PR is resolved
Projects
None yet
Development

No branches or pull requests

2 participants