Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global header/footer compat issues on make.w.org #60

Closed
Tracked by #44
ryelle opened this issue Jan 6, 2022 · 4 comments
Closed
Tracked by #44

Global header/footer compat issues on make.w.org #60

ryelle opened this issue Jan 6, 2022 · 4 comments
Assignees
Milestone

Comments

@ryelle
Copy link
Contributor

ryelle commented Jan 6, 2022

On make sites, it looks like the theme expects the header to load Open Sans, so the fonts are broken (Open Sans is not loaded, it falls back to serif headings & sans-serif body).

Screen Shot 2022-01-03 at 5 47 09 PM

Homepage - max width container is gone, fonts are all too big. container also missing on meetings page.

Screen Shot 2022-01-06 at 17 15 21

Header spacing is also off, and "get wordpress" button has underline

@ryelle ryelle self-assigned this Jan 6, 2022
@ryelle ryelle changed the title make homepage content styles messed up Global header/footer compat issues on make.w.org Jan 6, 2022
@ryelle ryelle added this to the News launch milestone Jan 7, 2022
@ryelle ryelle closed this as completed in 5cde8ec Jan 7, 2022
@dd32
Copy link
Member

dd32 commented Jan 13, 2022

Re-opening this based on d094153 - It looks like wp4-styles theme support isn't enough or something.

See https://wordpress.slack.com/archives/C02QB8GMM/p1642056619063500

@ryelle
Copy link
Contributor Author

ryelle commented Jan 13, 2022

I pushed fe9bde9 to fix this, but realized it might break the work done in #62 — checking that out now.

@ryelle
Copy link
Contributor Author

ryelle commented Jan 13, 2022

@dd32 I'm having trouble figuring out if broke anything— I can't sandbox planet or the codex, but looking at /wp-json/global-header-footer/v1/header/planet, it looks like the same files are output before & after. l don't see wporg-style & do see wp4.css, open sans & dashicons. Let me know if something's actually broken though.

@dd32
Copy link
Member

dd32 commented Jan 14, 2022

I think that works too, I think I was incorrect in changing the priority to later, I thought it fixed the problem I was chasing, but caused another.

@dd32 dd32 closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants