Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sass #1

Open
iandunn opened this issue Sep 21, 2021 · 3 comments
Open

Remove Sass #1

iandunn opened this issue Sep 21, 2021 · 3 comments

Comments

@iandunn
Copy link
Member

iandunn commented Sep 21, 2021

ideally, the theme would use postcss like wporg-mu-plugins does.

xref WordPress/wporg-mu-plugins#6 (review)

the sooner we do it, the easier it'll be, but i'm also leery of getting bogged down in non-essentials right now 🤔

8270ecd1f04223c53a9ffcc6a81fa118f5ba8a09 added %footer-archive-dark, %local-header-off-white, etc. If PostCSS doesn't have a similar concept, we might be able to convert them to regular classes, and have the templates add the class, but that would rely on WordPress/gutenberg#32939

we currently import some mixins, breakpoints, etc from gutenberg's sass. i'm not sure a good solution for that

there may be a tool that'll convert most sass to postcss automatically

@ryelle
Copy link
Contributor

ryelle commented Feb 28, 2022

Does this issue mean to remove Sass entirely? What would be the benefit to that? Most of the issues with complexity were fixed in the CSS refactor, and we're still using Sass features like mixins and extends.

@iandunn
Copy link
Member Author

iandunn commented Feb 28, 2022

Originally we planned on using PostCSS for the project; using SASS was just an artifact of BlockBase.

Using PostCSS would make it consistent w/ the global header and be more modern.

Integrating w/ Gutenberg dependencies might be tricky though.

@ryelle
Copy link
Contributor

ryelle commented Apr 22, 2022

I'm going to transfer this issue over to the parent theme repo — i think removing Sass from that theme & future children will be easier than trying to remove it from here, where we're so tied in to mixins & extends (we can always reconsider the idea if/when we make News a proper child of that parent).

@ryelle ryelle transferred this issue from WordPress/wporg-news-2021 Apr 22, 2022
@ryelle ryelle changed the title Migrate to PostCSS Remove Sass Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants