-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Theme: 404 page, links too dark #148
Comments
I've run an accessibility scan on the page and the links do meet the WCAG 2.1 AA minimum contrast ratio. I'm not sure what other color we would use here. @WordPress/meta-design what are your thoughts please? Noting that the standard 404 page used across much of WordPress.org has the same design. |
Despite what computer tools find 'adequate', it's not particular helpful for the lost soul (= the reader who lands on this page) to not get enough consideration to make the choices of alternative pages more prominent, or at least more readable. That applies also to the standard 404 pages, even if it were deployed a million times before. |
That color is used for text and the focus ring over dark backgrounds across the site. We can definitely revisit the decision, but to keep the style consistent across the site, we would need to revisit most sections to ensure it doesn't clash with other styles already implemented. |
Transferring to parent theme repo as these styles are not unique to Learn, only the content is different. |
Type of feedback
//dev
Description
On the 404 page, links offered are barely readable as they have color contrast issues with middle blue on black background.
Step-by-step reproduction instructions (optional)
Go to 404 page
Screenshots or screen recording (optional)
The text was updated successfully, but these errors were encountered: