Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Theme: 404 page, links too dark #148

Open
bph opened this issue Jul 16, 2024 · 5 comments
Open

New Theme: 404 page, links too dark #148

bph opened this issue Jul 16, 2024 · 5 comments

Comments

@bph
Copy link

bph commented Jul 16, 2024

Type of feedback

//dev

Description

On the 404 page, links offered are barely readable as they have color contrast issues with middle blue on black background.

Step-by-step reproduction instructions (optional)

Go to 404 page

Screenshots or screen recording (optional)

Screenshot 2024-07-16 at 17 42 21

@github-actions github-actions bot added the [Type] Bug Something isn't working label Jul 16, 2024
@adamwoodnz
Copy link
Contributor

I've run an accessibility scan on the page and the links do meet the WCAG 2.1 AA minimum contrast ratio. I'm not sure what other color we would use here. @WordPress/meta-design what are your thoughts please?

Noting that the standard 404 page used across much of WordPress.org has the same design.

@adamwoodnz adamwoodnz removed the [Type] Bug Something isn't working label Jul 16, 2024
@adamwoodnz
Copy link
Contributor

adamwoodnz commented Jul 16, 2024

@bph
Copy link
Author

bph commented Jul 17, 2024

Despite what computer tools find 'adequate', it's not particular helpful for the lost soul (= the reader who lands on this page) to not get enough consideration to make the choices of alternative pages more prominent, or at least more readable.

That applies also to the standard 404 pages, even if it were deployed a million times before.

@fcoveram
Copy link

That color is used for text and the focus ring over dark backgrounds across the site. We can definitely revisit the decision, but to keep the style consistent across the site, we would need to revisit most sections to ensure it doesn't clash with other styles already implemented.

@adamwoodnz adamwoodnz transferred this issue from WordPress/Learn Aug 6, 2024
@adamwoodnz adamwoodnz added the [Component] Theme Templates, patterns, CSS label Aug 6, 2024
@adamwoodnz
Copy link
Contributor

Transferring to parent theme repo as these styles are not unique to Learn, only the content is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In discussion
Status: 🛑 Pending discussion
Development

No branches or pull requests

4 participants