Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single photo page #4

Open
7 tasks
ryelle opened this issue Oct 17, 2024 · 2 comments
Open
7 tasks

Single photo page #4

ryelle opened this issue Oct 17, 2024 · 2 comments
Labels
[Component] Theme Templates, patterns, CSS

Comments

@ryelle
Copy link
Collaborator

ryelle commented Oct 17, 2024

Individual photo

Figma link

@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Oct 17, 2024
ryelle added a commit that referenced this issue Oct 18, 2024
@ryelle
Copy link
Collaborator Author

ryelle commented Oct 30, 2024

@fcoveram What is the logic for the featured image + grey background? Initially, I had set it up so that the grey box is a square, so it's the same height across all photos and has that top or side spacing like in the mockup. But I realized that the grey in the mockup is not square, so I've also tried 16:9, but then this doesn't have the top spacing (it would need a photo with an aspect ratio more extreme than 16:9).

Examples:

Landscape Portrait Square
Square Image Image Image
16:9 Image Image Image

This should have the same container aspect ratio on large and small screens, which is also not currently the case in the mockup.

@fcoveram
Copy link

My mistake. I thought the mockups were 16:9. The desktop version is close to the ratio but not fully accurate.

The idea was having a 16:9 in both desktop and mobile. So the 16:9 tests in the table above are the expected outcome.

I was looking the mockups again and I'm not sure about the gray as background color to outline the image container. What do you think of it? The outcome on dev feels different than a mockup so curious about your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Status: 📋 To do
Development

No branches or pull requests

2 participants