-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single photo page #4
Comments
@fcoveram What is the logic for the featured image + grey background? Initially, I had set it up so that the grey box is a square, so it's the same height across all photos and has that top or side spacing like in the mockup. But I realized that the grey in the mockup is not square, so I've also tried 16:9, but then this doesn't have the top spacing (it would need a photo with an aspect ratio more extreme than 16:9). Examples:
This should have the same container aspect ratio on large and small screens, which is also not currently the case in the mockup. |
My mistake. I thought the mockups were 16:9. The desktop version is close to the ratio but not fully accurate. The idea was having a 16:9 in both desktop and mobile. So the 16:9 tests in the table above are the expected outcome. I was looking the mockups again and I'm not sure about the gray as background color to outline the image container. What do you think of it? The outcome on dev feels different than a mockup so curious about your thoughts. |
great 👍🏻
I like the grey, but it's fairly easy to change the style of that container if you wanted. Maybe wait for the theme preview to be live so you can see it for real? |
Great. My main concern is users understand the grey area as part of the image. |
Figma link
The text was updated successfully, but these errors were encountered: