-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide tags with less than X sites on the Browse page #244
Comments
For what it's worth, I'm reading this as more of an editorial effort than a technical one. That if you click a tag and you only get two results, that's not a good experience begging the question why even have that tag in the first place? I agree with this, and lean towards either finding a way to use that tag on more sites, or remove that tag entirely. Previously we had a lot of cases like these, including a tag called "Eyewear", which would have two sites I believe. If I'm getting this feedback right, it may have been from a previous iteration, however, where we did have tags with very few sites, but I can't see that anymore. The fewest sites we have in a tag now is 4: You can still get to a place where you combine enough tags, categories and flavors that you get few or no sites. I think that's related to separate tag/category/flavor conversations, and is arguably fine. |
Here are my 2cents:
— Now personal thought: I think it should stay. And I think it is ok if users come back and say hey folks what do we need this for, to consider removing. Plus I think we hid the index (Tags page) well enough, so it will be rarely used. All in all, I wouldn't touch Tags page (other than hiding flavors) at the moment. Also keep in mind that this is more a subjective view. CC: @ndiego , @jasmussen |
We also should match the URL to the name in the breadcrumbs. Either 'filters' either 'browse'. But I was prefering simply calling them 'tags' or 'wayfinding'. Why?
So this can be confusing. I had this comment before, but didn't work because we have categories and flavors. |
Great feedback everyone. Let's leave the Browse page as is, and we will do a more thorough audit of the tags to try and ensure all tags have at least two sites. I'll take care of this. Given this direction, I am going to close the issue. |
I broke out this comment from #234.
On most laptops, the site grid will have 2 sites per row, so I would recommend that we hide tags from the Browse page if the term has less than 2 sites. Thoughts @jasmussen @marko-srb?
@renintw with the current tag implementation on Browse, how hard would this be to implement? If it's easy, it would be great to get this in ahead of launch, but this could be punted to post-launch if needed.
The text was updated successfully, but these errors were encountered: