Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker V2] Support private distribution repo #13

Open
Skiepp opened this issue Jul 21, 2024 · 5 comments
Open

[Docker V2] Support private distribution repo #13

Skiepp opened this issue Jul 21, 2024 · 5 comments

Comments

@Skiepp
Copy link

Skiepp commented Jul 21, 2024

This plugin can list docker images from DockerHub only.

It will be great to have it support private registries (non-docker hub) as well, which is the de-facto standandard for enterprise companies.

Documentation: https://distribution.github.io/distribution/spec/api/

Basically the api call changes from:
/docker/v2/namespaces/${url.organization}/repositories/${url.repository}/tags

To:
/docker/v2/${image_name}/tags/list

As for the authentication, it can be done by using an Oauth2 Bearer token, just like DockerHub

@pascalwilbrink
Copy link
Contributor

Thank you for your request:)
I will take a look at it

@pascalwilbrink
Copy link
Contributor

Hi @Skiepp,

can you try this version?
https://www.npmjs.com/package/@workm8/backstage-docker-tags/v/1.1.0-alpha

You can specify the Registry like following:

metadata:
  name: Grafana
  annotations:
    docker.com/repository: 'grafana/grafana'
    docker.com/registry: 'Docker'

Currently, you can choose between Docker and GitHub (Case sensitive).

@Skiepp
Copy link
Author

Skiepp commented Jul 22, 2024

Hi @pascalwilbrink
Thanks for reaching me so fast! 🥇

Can you check if the package had been correctly pushed to npm?
I cannot see the "dist" folder inside the package.


In addition, how are used the Docker and GitHub options? If I understand correctly:

  • Docker is for DockerHub
  • GitHub is for the DockerV2 registry (like GitHub i think)

Wouldn't be better something like:

  • DockerHub for Dockerhub
  • DockerV2 for others

It's just a suggestion to make the configuration easier to read.


Is the code in the CNCF_HTTP_API branch?
I can help you if you need, I just need a little hint on how to build it

Thanks a lot, Skiepp

@Skiepp
Copy link
Author

Skiepp commented Oct 1, 2024

Hi @pascalwilbrink,
I'd like to help you on supporting this feature, by submitting a PR.
Anyway, I could not find in GH the current code of 1.1.0-alpha (released on npm)

Can I ask you to push the updated code, so that I can implement this feature on the updated one?

Thanks a lot

@Skiepp
Copy link
Author

Skiepp commented Oct 22, 2024

Hi @pascalwilbrink,
just a gentle reminder about this.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants