You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In FireFox there is an error in syntheticDataTransferFactory, because the arrays files and types can be null instead of zero length.
In IE there is an error when dragging items from outside the browser, because IE forbids access to effectAllowed in this case.
I have a quick PR that prevents both of these errors.
I also wanted to discussion the possibility of changing the events, by changing all of the SyntheticEvent classes to each be a simple proxy that wraps an instance if JsObject, instead of copying all of the values from the object during construction. This was mentioned in #49 as a possible performance improvement, and I think it could improve the code as well. I am curious if anyone else would see any drawbacks or problems with this idea.
The text was updated successfully, but these errors were encountered:
In FireFox there is an error in syntheticDataTransferFactory, because the arrays files and types can be null instead of zero length.
In IE there is an error when dragging items from outside the browser, because IE forbids access to effectAllowed in this case.
I have a quick PR that prevents both of these errors.
I also wanted to discussion the possibility of changing the events, by changing all of the SyntheticEvent classes to each be a simple proxy that wraps an instance if JsObject, instead of copying all of the values from the object during construction. This was mentioned in #49 as a possible performance improvement, and I think it could improve the code as well. I am curious if anyone else would see any drawbacks or problems with this idea.
The text was updated successfully, but these errors were encountered: