Skip to content

Drag n drop bugs, FireFox and IE #61

Open
@grumpy

Description

@grumpy

In FireFox there is an error in syntheticDataTransferFactory, because the arrays files and types can be null instead of zero length.
In IE there is an error when dragging items from outside the browser, because IE forbids access to effectAllowed in this case.

I have a quick PR that prevents both of these errors.

I also wanted to discussion the possibility of changing the events, by changing all of the SyntheticEvent classes to each be a simple proxy that wraps an instance if JsObject, instead of copying all of the values from the object during construction. This was mentioned in #49 as a possible performance improvement, and I think it could improve the code as well. I am curious if anyone else would see any drawbacks or problems with this idea.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions