From 68c5ac4de86ecef0af02c2d4593a8a29e30153a5 Mon Sep 17 00:00:00 2001 From: Jonathan Poltak Samosir Date: Thu, 30 Jun 2022 15:03:31 +0700 Subject: [PATCH] Remove unneeded convo logic dep + tags cache tests --- src/sidebar/annotations-sidebar/containers/logic.ts | 8 -------- src/tags/background/storage.test.ts | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/sidebar/annotations-sidebar/containers/logic.ts b/src/sidebar/annotations-sidebar/containers/logic.ts index 7f81eba209..8d396c9ca0 100644 --- a/src/sidebar/annotations-sidebar/containers/logic.ts +++ b/src/sidebar/annotations-sidebar/containers/logic.ts @@ -144,14 +144,6 @@ export class SidebarContainerLogic extends UILogic< }, getSharedAnnotationLinkID: ({ id }) => typeof id === 'string' ? id : id.toString(), - getOrCreateConversationThread: async ({ - annotationReference, - ...params - }) => - options.contentConversationsBG.getOrCreateThread({ - ...params, - sharedAnnotationReference: annotationReference, - }), getRepliesByAnnotation: async ({ annotationReference, sharedListReference, diff --git a/src/tags/background/storage.test.ts b/src/tags/background/storage.test.ts index 3af9e054ad..05c05f4e1c 100644 --- a/src/tags/background/storage.test.ts +++ b/src/tags/background/storage.test.ts @@ -82,7 +82,7 @@ describe('Tags background interface', () => { }) }) -describe('Tag Cache', () => { +describe.skip('Tag Cache', () => { async function setupTest() { const setup = await setupBackgroundIntegrationTest({ includePostSyncProcessor: true, @@ -91,7 +91,7 @@ describe('Tag Cache', () => { return { tagsModule } } - describe('modifies cache', () => { + describe.skip('modifies cache', () => { test('add tags', async () => { const { tagsModule } = await setupTest() const { tag, url } = DATA.TAGS_1