[#33] Fix limitation of 3D path length #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason the Path has limited number of points to be drawn is that vertexBuffer indices are UNSIGNED_SHORT type and thus unique index values are limited due to "Max Short" value. Add IntBufferObject, make Path use it as drawState.elementBuffer. Change interiorElements, outlineElements and verticalElements type to Int. modified: worldwind/src/androidMain/kotlin/earth/worldwind/util/kgl/AndroidKgl.kt modified: worldwind/src/commonMain/kotlin/earth/worldwind/draw/DrawShapeState.kt new file: worldwind/src/commonMain/kotlin/earth/worldwind/render/buffer/IntBufferObject.kt modified: worldwind/src/commonMain/kotlin/earth/worldwind/shape/Path.kt modified: worldwind/src/commonMain/kotlin/earth/worldwind/util/kgl/Kgl.kt
PJHogan
previously approved these changes
Sep 25, 2023
Add basic `bufferData` implementation to AnddroidKgl, JoglKgl, LwjglKgl and WebKgl. modified: worldwind/src/commonMain/kotlin/earth/worldwind/render/buffer/FloatBufferObject.kt modified: worldwind/src/commonMain/kotlin/earth/worldwind/render/buffer/IntBufferObject.kt modified: worldwind/src/commonMain/kotlin/earth/worldwind/render/buffer/ShortBufferObject.kt modified: worldwind/src/commonMain/kotlin/earth/worldwind/shape/Polygon.kt modified: worldwind/src/jsMain/kotlin/earth/worldwind/util/kgl/WebKgl.kt
PJHogan
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason the Path has limited number of points to be drawn is that vertexBuffer indices are UNSIGNED_SHORT type and thus unique index values are limited due to "Max Short" value.
Add IntBufferObject, make Path use it as drawState.elementBuffer. Change interiorElements, outlineElements and verticalElements type to Int.