Implement cached texture uploads utilizing PF_State
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will optimize the case where either the source-layer is either a static image or a low-framerate gif by identifying the uploaded contents of the image with a P_State and re-using the uploaded image rather than uploading it each frame.
Wunkolo
force-pushed
the
gpu-upload-cache
branch
from
596f402
to
9277726
Compare
|
Red frames indicate a GPU upload of the input texture. With a 12.5 gif in a 50fps composition, the input-texture is now only uploaded to the GPU when the incoming frame index is unique from the previous. |
Having the additional ImageCreateInfo does not really make sense in this case since the PF_State is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
PF_Stateto conservatively upload the InputTexture only when needed. This optimizes the case where the source input layer is a static image, a time-remapped video, or a low-framerate image.Ex, in the case of a static image, the source texture is only uploaded once, keeping track of its
PF_State, and subsequent render requests will re-use this uploaded texture.The coherency of
PF_Stateneeds to be validated a bit.Resolves #5