Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] default language conflict #28

Open
gymgym1212 opened this issue Jun 16, 2022 · 7 comments · Fixed by #63
Open

[Bug] default language conflict #28

gymgym1212 opened this issue Jun 16, 2022 · 7 comments · Fixed by #63

Comments

@gymgym1212
Copy link
Contributor

Switching the language for the first time does not work.
When the page loads, the language is Chinese at first, but it is still Chinese after clicking on the switch.
The toggle button does not work properly until after the first toggle.

@tyn1998
Copy link
Member

tyn1998 commented Feb 22, 2023

I'm not sure if the bug has been fixed as language switching function works well on my side at the moment:

2023-02-22.10.57.33.mov

@andyhuang18
Copy link
Collaborator

When the default interface is in Chinese, problems will occur on the first click

Open.Leaderboard.-.-.Microsoft.Edge.2023-02-22.11-04-15.mp4

@tyn1998
Copy link
Member

tyn1998 commented Feb 22, 2023

Reproduced:

  1. set language to en
  2. refresh the page
  3. now zh is the default language
  4. click toggle button, the problem is reproduced

@andyhuang18
Copy link
Collaborator

Reproduced:

  1. set language to en
  2. refresh the page
  3. now zh is the default language
  4. click toggle button, the problem is reproduced

Copy that!I will continue to work on this issue~

@tyn1998
Copy link
Member

tyn1998 commented Feb 22, 2023

I just put steps to reproduce the bug here. The issue was fixed by your PR :)

@wj23027
Copy link
Contributor

wj23027 commented Feb 22, 2023

I find that now when the language is English there are still some problems.

Open.Leaderboard.-.-.Microsoft.Edge.2023-02-22.13-18-16.mp4

@tyn1998
Copy link
Member

tyn1998 commented Feb 22, 2023

My fault, I didn't test it in the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants