Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KERNAL: Regression in load in ROM v47 breaks RALLYSPEEDWAY when loading via IEC #367

Open
tmcintos opened this issue Sep 29, 2024 · 1 comment · May be fixed by #378
Open

KERNAL: Regression in load in ROM v47 breaks RALLYSPEEDWAY when loading via IEC #367

tmcintos opened this issue Sep 29, 2024 · 1 comment · May be fixed by #378
Assignees
Labels
bug Something isn't working

Comments

@tmcintos
Copy link

tmcintos commented Sep 29, 2024

Please review my comments here:

f629cff#r147340847

Copied here for reference:

ld81	lda verck
	dec
	beq ld64        ; loading to VRAM

Isn't this test wrong in the case that >1 VRAM bank is being loaded? In that case, verck may be >1 before it is decremented, as I understand from the comments above.

I identified a regression here between ROM v46 and v47/v48 with RALLYSPEEDWAY when loading TRAFFIC.BIN into VRAM. v47/v48 go through this path to send a premature UNTALK command after reading something like 492 bytes from the file. Similar errors occur with subsequently-loaded files and the game errors out before reaching the title screen. With ROM v46 the game is able to launch as expected.

I observe this with my custom emulator that emulates a CX16 with disk attached via IEC (no kernel intercepts or other shortcuts).

I'm unable to reproduce the problem with the official x16emu, since I can't successfully boot to the prompt when supplying the -serial command line option to x16emu_macos_m1-r48 (running on macOS 15.1 beta, if it's relevant). If the -serial option worked, I expect we'd see the same thing there. I'd also expect to see the problem on a real CX16 with IEC-attached drive, but I don't have one to test with.

The problem does not occur on x16emu_macos_m1-r48 when running without -serial or with the -sdcard option, which I presume will bypass this path.

@tmcintos
Copy link
Author

tmcintos commented Sep 29, 2024

maybe this will help

Looks like spam/malware

@X16Community X16Community deleted a comment Oct 4, 2024
@mooinglemur mooinglemur added the bug Something isn't working label Oct 4, 2024
@mooinglemur mooinglemur self-assigned this Oct 4, 2024
@mooinglemur mooinglemur linked a pull request Dec 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants