Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KERNAL] handle two LOAD edge cases #378

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[KERNAL] handle two LOAD edge cases #378

wants to merge 2 commits into from

Conversation

mooinglemur
Copy link
Collaborator

@mooinglemur mooinglemur commented Dec 20, 2024 •
edited
Loading

  • The logic that switches to bytewise load just below $9F00 did not check for EOI, leading to an erroneous extra byte read after EOI in cases where:
    • A load which only required a single MACPTR was started after $9D00.
    • A longer load ends such that the pointer lands after $9D00 on the same MACPTR that reaches the file's end.

reported by tony3068 (Discord)

Closes #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fulgen301 Fulgen301 Awaiting requested review from Fulgen301

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KERNAL: Regression in load in ROM v47 breaks RALLYSPEEDWAY when loading via IEC
1 participant
@mooinglemur