Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean task doesn't have access to build configuration/code #80

Open
Xymanek opened this issue Dec 19, 2021 · 0 comments
Open

Clean task doesn't have access to build configuration/code #80

Xymanek opened this issue Dec 19, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Xymanek
Copy link
Member

Xymanek commented Dec 19, 2021

The clean task is currently a separate script, which is already problematic:

  • Fix mod project paths containing spaces #56 isn't applied to cleaning logic
  • clean_cooker_output.ps1 had to be a separate file (it's called from both clean and build) and duplicates logic from build:
    # TODO: duplicates the logic in build_common.ps1
    $actualTfcSuffix = "_$($modNameCanonical)_DLCTFC_XPACK_"
    $cookerOutputPath = [io.path]::combine($sdkPath, 'XComGame', 'Published', 'CookedPCConsole')
  • clean.ps1 is forced to use some flaky logic due to lack of access to project's ContentOptions.json
    # This needs to be before $srcDirectory\BuildCache is deleted - otherwise we will miss our collection maps
    # This is dumb, yes, but to fix this we need to rework how BuildProject is used from build.ps1 (and here)
    CleanModAssetCookerOutput $sdkPath $modName @("$srcDirectory\$modName\ContentForCook", "$srcDirectory\BuildCache\CollectionMaps")

Fixing this however requires significantly changing how individual projects consume X2MBC (and some internal refactor of X2MBC)

cc @robojumper

@Xymanek Xymanek added the enhancement New feature or request label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant