From 0af57caa21a53bbb4efff24a34ba2471ce262407 Mon Sep 17 00:00:00 2001 From: Jo Grimstad Date: Sun, 10 Nov 2019 21:51:16 +0800 Subject: [PATCH] #44 Team Chimple: Fix incorrect serial numbers in tablet tracker - Iterate columns up until "Serial #14" --- .../extract_serial_numbers_not_found_in_tablet_tracker.py | 4 ++-- .../extract_serial_numbers_not_found_in_tablet_usage_data.py | 4 ++-- .../serial-numbers-not-found-in-tablet-tracker.csv | 2 -- .../serial-numbers-not-found-in-tablet-usage-data.csv | 3 +++ 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_tracker.py b/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_tracker.py index 4e073835..6df9d478 100644 --- a/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_tracker.py +++ b/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_tracker.py @@ -25,10 +25,10 @@ logging.debug("csv_row: {}".format(csv_row)) - # Iterate serial columns ("Serial #1" --> "Serial #7") + # Iterate serial columns ("Serial #1" --> "Serial #14") removal_count = 1 column_index = 2 - while removal_count <= 7: + while removal_count <= 14: serial_number = csv_row[column_index] logging.debug("Serial #{0}: {1}".format(removal_count, serial_number)) diff --git a/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_usage_data.py b/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_usage_data.py index 19b2d718..8bdb589d 100644 --- a/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_usage_data.py +++ b/team-KITKIT/tablet-tracker/extract_serial_numbers_not_found_in_tablet_usage_data.py @@ -59,10 +59,10 @@ logging.debug("csv_row: {}".format(csv_row)) - # Iterate serial columns ("Serial #1" --> "Serial #7") + # Iterate serial columns ("Serial #1" --> "Serial #14") removal_count = 1 column_index = 2 - while removal_count <= 7: + while removal_count <= 14: serial_number = csv_row[column_index] logging.debug("Serial #{0}: {1}".format(removal_count, serial_number)) diff --git a/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-tracker.csv b/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-tracker.csv index 83b63049..10a5e8f5 100644 --- a/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-tracker.csv +++ b/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-tracker.csv @@ -45,7 +45,5 @@ serial_number 5B16001020 6113001057 6116002734 -5B12002782 6118002226 -5A27001997 6116001841 diff --git a/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-usage-data.csv b/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-usage-data.csv index 4ab27f34..5a1b7edf 100644 --- a/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-usage-data.csv +++ b/team-KITKIT/tablet-tracker/serial-numbers-not-found-in-tablet-usage-data.csv @@ -47,6 +47,9 @@ serial_number 5A27001825 6116001671 5B20001858 +5A22000758 6111002515 6111002285 +6116001981 +6116001438 5A27001392