Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyPi] Deprecation warning #33

Open
JPapir opened this issue Aug 31, 2024 · 5 comments
Open

[PyPi] Deprecation warning #33

JPapir opened this issue Aug 31, 2024 · 5 comments

Comments

@JPapir
Copy link
Collaborator

JPapir commented Aug 31, 2024

When installing Qumin with pypi, I get the following warning:

DEPRECATION: qumin is being installed using the legacy 'setup.py install' method, 
because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. 
pip 23.1 will enforce this behaviour change. A possible replacement is to enable 
the '--use-pep517' option. 
Discussion can be found at https://github.com/pypa/pip/issues/8559

If I understand it well, we should use a pyproject.toml file instead of setup.py ? Don't know it this is project related or only wrong setups on my side. Do not hesitate to close if irrelevant.

@XachaB
Copy link
Owner

XachaB commented Aug 31, 2024

Hi Jules, I think if you just install wheel, the warning will disappear.

But it is correct that it would be better for us to migrate from setup.cfg to pyproject.toml, so I'll keep the issue :)

@JPapir
Copy link
Collaborator Author

JPapir commented Aug 31, 2024

I think if you just install wheel, the warning will disappear.

That's what I thought at first, but then I added wheel in my requirements.txt so that it installs before Qumin, and still the same warning. I will try again once I will have a good internet connection.

@XachaB
Copy link
Owner

XachaB commented Aug 31, 2024

No, I think you need wheel first, in your environment, in order to install the Qumin with wheel (not as a dependency of Qumin). In the same way that you don't add "pip" as a requirement, I think.

I'm also with a low connection (currently in a bus, later in several trains), but having a look at your first MR :)

@JPapir
Copy link
Collaborator Author

JPapir commented Aug 31, 2024

All right, I will try that, thanks.
Currently in a Flixbus also ;)

@XachaB
Copy link
Owner

XachaB commented Sep 2, 2024

You're right, I get this too.

I think we need to both migrate to pyproject.toml and for me to learn again how to distribute projects with this setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants