Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate com.zaxxer.hikari to avoid conflicts with other plugins #18

Open
A248 opened this issue Aug 29, 2021 · 2 comments
Open

Relocate com.zaxxer.hikari to avoid conflicts with other plugins #18

A248 opened this issue Aug 29, 2021 · 2 comments

Comments

@A248
Copy link

A248 commented Aug 29, 2021

If you open up the GemsEconomy jar, you'll find com/zaxxer/hikari because GemsEconomy uses HikariCP.

However, the way HikariCP has been included in GemsEconomy means that GemsEconomy's HikariCP can clash with other plugins if those other plugins also use the same library. Two plugins relying on different versions of the same library will run into issues if both of them use the same namespace. In this case, the namespace is com.zaxxer.hikari.

As the CraftBukkit wiki warns:

Plugins should relocate their dependencies to avoid conflicts between plugins, which may result in nausea, vomiting, upset stomach, and/or death unintended behavior or exceptions.
https://bukkit.fandom.com/wiki/Using_External_Libraries_with_Plugins

@A248
Copy link
Author

A248 commented Aug 29, 2021

Besides com.zaxxer.hikari, GemsEconomy also includes org.slf4j. Like HikariCP, the slf4j library should be relocated in the same fashion.

@ajh123
Copy link

ajh123 commented Aug 12, 2023

On the main spigot page it says this mod is "DISCONTINUED". However I have found https://github.com/ArcanePlugins/Polyconomy and https://github.com/ArcanePlugins/Treasury (to be used together) which offer similar features to GemsEconomy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants