Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorecard - Not copied by mastercontroller when in subdirectory #521

Open
rschwietzke opened this issue Aug 12, 2024 · 4 comments
Open

Scorecard - Not copied by mastercontroller when in subdirectory #521

rschwietzke opened this issue Aug 12, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@rschwietzke
Copy link
Contributor

All property files support subdirectories. The scorecard feature does support that too (reading) but it appears that the MC cannot deal with a definition file in a subdirectory within config when preparing the final results.

@rschwietzke rschwietzke added the bug Something isn't working label Aug 12, 2024
@h-arlt
Copy link
Contributor

h-arlt commented Aug 12, 2024

We don't have any special handling for Scorecard definition files.
As long as it is

  • named correctly (must end on .json),
  • readable and
  • located in config directory (regardless of the nesting level)

it should be copied as part of the test configuration when downloading results.

Need to debug this further.

@h-arlt h-arlt self-assigned this Aug 12, 2024
@h-arlt
Copy link
Contributor

h-arlt commented Aug 12, 2024

Well, it seems that XLT copies only files at 1st level below config plus those that are included using property includes. So, this is not related to the Scorecard feature but a general issue.

@rschwietzke
Copy link
Contributor Author

rschwietzke commented Aug 12, 2024 via email

@h-arlt
Copy link
Contributor

h-arlt commented Aug 13, 2024

XLT copies only files at 1st level below config plus those that are included using property includes.

You have to include it explicitly when it resides in a sub-directory. Otherwise, it won't be copied (although users might expect it to be).

Assume for example, users store their load test profiles in a sub-directory named 'profiles'. Then, only the currently active load test profile as configured by property com.xceptance.xlt.testPropertiesFile will be copied but not the others. Whether or not this is expected depends on the point of view. As long as the other files are not part of the effective load test configuration, they don't have to be copied. Nevertheless, they are part of the overall load test configuration and may be copied as well.

Regarding scorecard configuration files, they are no properties files and thus cannot be included. So, the copy-when-included path is not applicable for them. As a consequence, scorecard definition files have to be located at first level below config in order to get copied. So far for the explanation of the current state.
Question now is: how do we want to proceed from here? Do we want to handle scorecard definition files somewhat specifically? Or, do we want to rethink the current approach (e.g. copy all files inside of config directory that match a certain file filter instead of those at 1st level only)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants