Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat auto round #1064

Merged
merged 48 commits into from
Dec 3, 2024
Merged

Feat auto round #1064

merged 48 commits into from
Dec 3, 2024

Conversation

pablomlago
Copy link
Collaborator

@pablomlago pablomlago commented Oct 20, 2024 •
edited
Loading

Reason for this PR

Implement AutoRound within Brevitas (see https://github.com/intel/auto-round, https://arxiv.org/pdf/2309.05516)

Changes Made in this PR

Incorporate AutoRound, refactored learned round methods into a single common interface.

Testing Summary

New tests for the learned round utilities, replicate results from AutoRound repo.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@pablomlago pablomlago changed the title [DRAFT, DO NOT MERGE] Feat auto round Feat auto round Nov 4, 2024
@nickfraser
Copy link
Collaborator

@pablomlago, can you switch this target dev not master?

@pablomlago pablomlago changed the base branch from master to dev November 4, 2024 15:59
Giuseppe5
Giuseppe5 reviewed Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@Giuseppe5 Giuseppe5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review, I'll play with the code a bit in the meantime while you address these comments

src/brevitas/core/function_wrapper/auto_round.py Outdated Show resolved Hide resolved
src/brevitas/optim/sign_sgd.py Show resolved Hide resolved
src/brevitas/optim/sign_sgd.py Show resolved Hide resolved
src/brevitas/optim/sign_sgd.py Outdated Show resolved Hide resolved
src/brevitas/optim/sign_sgd.py Show resolved Hide resolved
src/brevitas/optim/sign_sgd.py Show resolved Hide resolved
src/brevitas_examples/llm/benchmark/llm_benchmark.py Outdated Show resolved Hide resolved
src/brevitas_examples/llm/llm_quant/learned_round_utils.py Show resolved Hide resolved
@Giuseppe5 Giuseppe5 added the next release PRs which should be merged for the next release label Nov 7, 2024
@Giuseppe5 Giuseppe5 self-requested a review December 2, 2024 23:21
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 December 2, 2024 23:33
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 December 2, 2024 23:43
@Giuseppe5 Giuseppe5 requested review from Giuseppe5 and removed request for Giuseppe5 December 3, 2024 00:15
@Giuseppe5 Giuseppe5 merged commit 8e0c399 into Xilinx:dev Dec 3, 2024
376 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser Awaiting requested review from nickfraser

@Giuseppe5 Giuseppe5 Awaiting requested review from Giuseppe5

Assignees
No one assigned
Labels
next release PRs which should be merged for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablomlago @nickfraser @Giuseppe5