Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test (mx): add reference impl for MXFloat #1068

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Test (mx): add reference impl for MXFloat #1068

merged 1 commit into from
Oct 31, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Oct 23, 2024 •
edited
Loading

Reason for this PR

Add more MX tests
Depends on #1071

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 force-pushed the test_mx branch 3 times, most recently from b4b7926 to 7494e2e Compare October 28, 2024 14:04
@Giuseppe5 Giuseppe5 marked this pull request as ready for review October 29, 2024 09:22
@Giuseppe5 Giuseppe5 force-pushed the test_mx branch 2 times, most recently from 57ab1fe to f90ac34 Compare October 29, 2024 10:15
@Giuseppe5 Giuseppe5 requested a review from nickfraser October 30, 2024 15:10
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser October 31, 2024 08:58
@Giuseppe5 Giuseppe5 changed the title Test mx Test (mx): add reference impl for MXFloat Oct 31, 2024
@Giuseppe5 Giuseppe5 merged commit 9696adb into Xilinx:dev Oct 31, 2024
23 checks passed
@nickfraser
Copy link
Collaborator

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser Awaiting requested review from nickfraser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser