Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (export): qonnx minifloat export #1070

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Feat (export): qonnx minifloat export #1070

merged 5 commits into from
Nov 7, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Oct 23, 2024 •
edited
Loading

Reason for this PR

Minifloat export to QONNX

Changes Made in this PR

Extended QONNX export to support Weight/Activations export of generic minifloat

Testing Summary

Simple test to generate the ONNX file. Since we don't have the corresponding mathematical implementation, we can't verify the math.

Risk Highlight

We can only rely on visual inspection of the ONNX.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@maltanar

@Giuseppe5 Giuseppe5 requested a review from maltanar October 23, 2024 22:31
@Giuseppe5 Giuseppe5 changed the title Feat (export): qonnx minifloat export [DO NOT MERGE] Feat (export): qonnx minifloat export Oct 25, 2024
maltanar
maltanar requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@maltanar maltanar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Generally looking good, requesting changes to comply with the updated spec plus suggested a few minor improvements

src/brevitas/export/onnx/qonnx/handler.py Outdated Show resolved Hide resolved
src/brevitas/export/onnx/qonnx/handler.py Show resolved Hide resolved
src/brevitas/export/onnx/qonnx/handler.py Outdated Show resolved Hide resolved
src/brevitas/export/onnx/qonnx/handler.py Outdated Show resolved Hide resolved
src/brevitas/export/onnx/qonnx/handler.py Outdated Show resolved Hide resolved
src/brevitas/export/onnx/qonnx/function.py Outdated Show resolved Hide resolved
@Giuseppe5
Copy link
Collaborator Author

Everything should be addressed, let me know if this matches QONNX specs

@Giuseppe5 Giuseppe5 requested a review from maltanar October 30, 2024 14:18
@Giuseppe5 Giuseppe5 changed the title [DO NOT MERGE] Feat (export): qonnx minifloat export Feat (export): qonnx minifloat export Oct 30, 2024
maltanar
maltanar approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@maltanar maltanar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Giuseppe5 Giuseppe5 added the next release PRs which should be merged for the next release label Nov 7, 2024
@Giuseppe5 Giuseppe5 merged commit d7d88c6 into Xilinx:dev Nov 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltanar maltanar maltanar approved these changes

Assignees
No one assigned
Labels
next release PRs which should be merged for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @maltanar