Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (brevitas_examples/llm): remove dependencies from optimum-amd #1094

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Nov 16, 2024

Reason for this PR

Remove circular dependencies between brevitas and optimum-amd

Changes Made in this PR

Brevitas now implements all the functions required for the LLM entrypoint.

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 requested a review from nickfraser November 16, 2024 22:15
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser November 18, 2024 08:22
@nickfraser
Copy link
Collaborator

Please also remove optimum-amd from requirements-llm.txt & from noxfile.py as well.

Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove single unused import. I think the rest are required.

requirements/requirements-llm.txt Outdated Show resolved Hide resolved
@Giuseppe5 Giuseppe5 requested a review from nickfraser November 28, 2024 15:12
@Giuseppe5 Giuseppe5 added the next release PRs which should be merged for the next release label Nov 28, 2024
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more references then LGTM!

src/brevitas_examples/llm/README.md:- optimum-amd (install from main)
tests/brevitas_examples/test_llm.py:# LLM example depends on optimum-amd, which requires PyTorch>=2.2

@Giuseppe5 Giuseppe5 merged commit 1ca8d7a into Xilinx:dev Dec 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs which should be merged for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants