Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (examples/llm): Specify experiments via YAML files #1116

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

nickfraser
Copy link
Collaborator

Add ability to specify the configuration of an experiment using the LLM example as a YAML file, which would easier to share with colleagues. Adding --config <yaml_file> will attempt to override the main.py defaults from the user provided YAML file. The user may still override these by adding furthering key/word arguments via the commandline.

@nickfraser nickfraser force-pushed the feat/llm_yaml_config branch 2 times, most recently from 44cb864 to 911a5cd Compare December 7, 2024 12:43
@Giuseppe5
Copy link
Collaborator

Would it be possible to use the more structured yaml to group together params that make sense to group together?
E.g., all rotation equalization stuff.

The list of args will only grow, but maybe this could help us keeping it somewhat organized.

@nickfraser
Copy link
Collaborator Author

Would it be possible to use the more structured yaml to group together params that make sense to group together?

I think this is a good idea, but my intuition is to save this for a future PR.

@nickfraser nickfraser marked this pull request as ready for review December 16, 2024 12:10
@Giuseppe5 Giuseppe5 changed the title Feat (ex/llm): Specify experiments via YAML files Feat (examples/llm): Specify experiments via YAML files Dec 17, 2024
@nickfraser nickfraser requested a review from Giuseppe5 December 17, 2024 17:14
@nickfraser nickfraser merged commit fd01451 into Xilinx:dev Dec 19, 2024
388 of 396 checks passed
@nickfraser nickfraser deleted the feat/llm_yaml_config branch December 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants