Feat (brevitas_examples/llm): correct scale init with CPU offloading #1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Offload might cause models to end up on CPU + GPU.
If that is the case, the initialization of scale factor is not correct, since the scales that are on CPU are forgotten because of the offload.
This allows to initialize and fix the scales correctly.
Changes Made in this PR
post_forward
has now a hook that stores the new parameters, if these have been updated, like the scale post initialization.Testing Summary
NA
Risk Highlight
NA
Checklist
dev
branch.