Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (brevitas_examples/llm): inference_mode support #1129

Merged
merged 9 commits into from
Dec 17, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Dec 13, 2024

Reason for this PR

Use quant_inference_mode for inference, and expand the classes supported by quant_inference_mode

Changes Made in this PR

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 requested a review from nickfraser December 16, 2024 15:41
@Giuseppe5 Giuseppe5 requested review from nickfraser and removed request for nickfraser December 16, 2024 16:05
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding this to the SDXL example as well? Otherwise, LGTM!

@Giuseppe5
Copy link
Collaborator Author

We already have this in SDXL IIRC, since we also use torch.compile there, for which quant_inference_mode is required

@Giuseppe5
Copy link
Collaborator Author

Nevermind, I had it in a separate branch. I will merge this and open a new one for SDXL + compile

@Giuseppe5 Giuseppe5 merged commit f8c6d64 into Xilinx:dev Dec 17, 2024
384 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants