Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct exec of FINN exported CNVs failed on random input #150

Closed
volcacius opened this issue May 14, 2020 · 2 comments
Closed

Correct exec of FINN exported CNVs failed on random input #150

volcacius opened this issue May 14, 2020 · 2 comments
Labels
bug Something isn't working export tests Anything related to tests

Comments

@volcacius
Copy link
Contributor

Track failure of the tests reported here https://github.com/Xilinx/brevitas/actions/runs/103974632.
Execution of exported CNV models (1b1b untrained and 2b2b pretrained) failed to the match the result from Brevitas on randomly generated input. Can't reproduce as the input was generated through numpy without the random seed being set. Best thing is probably to throw Hypothesis at it.

@volcacius volcacius changed the title Correct exec of FINN exported models failed on random input Correct exec of FINN exported CNVs failed on random input May 14, 2020
@volcacius volcacius added bug Something isn't working export tests Anything related to tests labels May 14, 2020
@maltanar
Copy link
Collaborator

We've seen a couple more export tests randomly fail for CNV export on w1a1 trained:

https://github.com/Xilinx/brevitas/pull/171/checks?check_run_id=765945395
https://github.com/Xilinx/brevitas/pull/171/checks?check_run_id=765945447

This may or may not be related to some random failures for activation exports we are seeing reported in this issue:

#173

@volcacius
Copy link
Contributor Author

Closing here, move to #173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working export tests Anything related to tests
Projects
None yet
Development

No branches or pull requests

2 participants