Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QuantDropout #861

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Remove QuantDropout #861

merged 1 commit into from
Feb 20, 2024

Conversation

OscarSavolainen
Copy link
Contributor

@OscarSavolainen OscarSavolainen commented Feb 18, 2024 •
edited
Loading

Purpose of this PR

  • Remove unused QuantDropout functionality. Issue: Remove QuantDropout module #743.
  • Gaining some minor experience with the dev & PR process by taking an (extremely) small task.

Changes made in this PR

Removed QuantDropout class

This was an entirely unused class in the codebase.

closes #743

@Giuseppe5 Giuseppe5 self-requested a review February 19, 2024 08:38
@capnramses
Copy link
Collaborator

Thanks for contributing @OscarSavolainenDR !
I think we can merge this into dev after our current release patch is out.

@OscarSavolainen
Copy link
Contributor Author

Thanks for contributing @OscarSavolainenDR ! I think we can merge this into dev after our current release patch is out.

No prob! Thanks, let me know if I need to rebase onto anything!

@Giuseppe5 Giuseppe5 merged commit caf0338 into Xilinx:dev Feb 20, 2024
347 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Giuseppe5 Giuseppe5 Giuseppe5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OscarSavolainen @capnramses @Giuseppe5