Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (float): adding new attributes to proxy and quant tensor #1072

Merged
merged 9 commits into from
Oct 28, 2024

Conversation

i-colbert
Copy link
Collaborator

@i-colbert i-colbert commented Oct 25, 2024

Reason for this PR

Adding features to float quant tensor and proxy for symmetry with integer quantizers.

Changes Made in this PR

Added .bit_width() to float quant proxy and .int() to float quant tensor.

Testing Summary

Adding tests to check .int() dynamic range and _CacheIO behavior.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@i-colbert i-colbert changed the title Feat/floatquant Feat (float): adding new attributes to proxy and quant tensor Oct 25, 2024
@i-colbert i-colbert added the next release PRs which should be merged for the next release label Oct 26, 2024
@Giuseppe5 Giuseppe5 self-requested a review October 28, 2024 10:02
@Giuseppe5 Giuseppe5 merged commit a215fc4 into Xilinx:dev Oct 28, 2024
44 of 46 checks passed
@i-colbert i-colbert deleted the feat/floatquant branch October 28, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs which should be merged for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants