Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not showing for loot and roll frames #17

Open
stinkybagel opened this issue Feb 3, 2023 · 18 comments
Open

Icons not showing for loot and roll frames #17

stinkybagel opened this issue Feb 3, 2023 · 18 comments
Labels
bug Something isn't working

Comments

@stinkybagel
Copy link

Icons do not show correctly on either the loot frame or the roll frame. It instead shows a black box.
wow-loot-frame-issue

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

Thanks for reporting this. I'm not sure what's causing it.

It looks like you're on classic, correct?

It's been reported here: https://www.wowace.com/projects/xloot/issues/212

But just like there, I don't have access to classic, and without errors or ideas I don't know what's going on. A cursory googling didn't show anything recent with GetLootSlotInfo not returning a working icon or anything related, and it seems to work on live, correct?

@stinkybagel
Copy link
Author

stinkybagel commented Feb 3, 2023

Hello, thanks for the quick reply. Yes this is happening on Classic Era/SoM, game version 1.14.3. It seems to have happened with the recent WoW classic WoTLK Patch for Phase 2 Ulduar? That is when I noticed it has stopped working.

Oddly enough, I do not see this issue on WoW Classic WoTLK 3.4.1.

I am happy to try and run a debugger or some way to capture the errors. I am not too familiar with the preferred options to do so though. For now I will turn on lua errors on the console and see if I come across anything.

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

I have no idea what would be causing it. Thanks for trying to bisect.

The only thing I could suggest is opening XLoot Frame\Frame.lua and finding
self.texture_item:SetTexture(slotData.icon)
and adding
xprint("%s texture: %s":format(slotData.name, slotData.icon))
before it.

Then /reload and show me what it says when it shows you blanks.

@stinkybagel
Copy link
Author

Maybe I am dumb but do you mean like this? Because both of these throw a LUA error due to syntax.

Message: Interface\AddOns\XLoot_Frame\Frame.lua:693: ')' expected near ':'
Time: Thu Feb 2 18:07:56 2023
Count: 2


692 -- Icon
693 xprint("%s texture: %s":format(slotData.name, slotData.icon))
694 self.texture_item:SetTexture(slotData.icon)

OR

692 -- Icon
693 xprint("%s texture: %s":format(slotData.name, slotData.icon))self.texture_item:SetTexture(slotData.icon)

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

The first one, but I gave you a typo anyway.
xprint(("%s texture: %s"):format(slotData.name, slotData.icon))
should work

@stinkybagel
Copy link
Author

stinkybagel commented Feb 3, 2023

Hello, that worked, thanks!

So I see no visual change in behavior.

Chat printed:
XLoot: 35 Copper texture: 133789
XLoot: Murloc Fin texture: 134304
wow-loot-frame-issue-after-change

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

It's the correct FileDataID as shown here

I don't know why it wouldn't work 😕 Thanks for checking. You can remove the line, not that you'd really want to use it while it's not showing you any icons anyway.

Given it works in the other versions, my only guess is it's some obtuse new wow bug. It sets the texture the same way the vanilla loot frame does.

@stinkybagel
Copy link
Author

No worries, thank you also for trying some quick things. I saw a commenter on WoWAce mentioned the latest version of 9-xx was working, so I will try that as well.

@stinkybagel
Copy link
Author

I can confirm that the 9.2.7-1 release is working.
9271-error-working

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

Interesting. Would you be willing to add the same line to that version and show me what it says? It should be the same, but I'd like to verify.

Also, can you confirm this is on an official classic server?

@stinkybagel
Copy link
Author

stinkybagel commented Feb 3, 2023

Yes this server I am testing from is Shadowstrike, under the Seasonal Tab on WoW Classic from USA. I have another character on Whitemane, under the Classic Era tab from USA. Both exhibit the same issue with the 10-xx version.

@stinkybagel
Copy link
Author

PFA print results in picture to confirm. Using 9.2.7-1 version, adding print line.

XLoot: 54 Copper texture: 133789
XLoot: Thick-shelled Clam texture: 134432
wow-loot-frame-issue--NEW-PRINT-97

@stinkybagel
Copy link
Author

I also noticed the frame itself in 10-xx version is darker, is there a chance that something is obfuscating the window visually, rather than it being an icon/id failing to be pulled?

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

That seems likely to be related to the gradient changes between those two versions due to errors people were getting. It looks like it's less truly fixed, and more just quelled.

I'll look into that and report the texture issue. I see something similar in the WoWUI discord.

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

I also noticed the frame itself in 10-xx version is darker, is there a chance that something is obfuscating the window visually, rather than it being an icon/id failing to be pulled?

Would you be able to confirm if 10-x has the same black background/no gradient visual on other game versions for you?

@stinkybagel
Copy link
Author

stinkybagel commented Feb 3, 2023

At the moment I do not have retail installed, but I was able to check WoW Classic WoTLK 3.4.1 on server Whitemane (US) using 10-xx, and it doesn't have the dark background/gradient issue. I'd assume retail has similar behavior to WoTLK and doesn't have the issue either in 10-xx.

Seems to be just be WoW Classic 1.14.3 SoM/Era servers affected by 10-xx.

wow-loot-frame-issue-wotlk-10x

@Xuerian
Copy link
Owner

Xuerian commented Feb 3, 2023

I appreciate you checking those for me.

@stinkybagel
Copy link
Author

No problem. Let me know if you need me to test anything else. For now, I'm using 9.2.7-1 on Classic Era content. Thanks

@Xuerian Xuerian added the bug Something isn't working label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants