Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/BAR-140] 기존 도커 이미지 삭제 및 빌드 실패 해결 #33

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

miro-ring
Copy link
Contributor

Summary

구현 내용 및 작업한 내역을 요약해서 적어주세요

  • 186864a 빌드 실패 해결을 위한 타입 선언
  • 13c7ab5 deploy yaml 수정

To Reviewers

strict: true 선언으로 인해 발생하는 타입 에러들을 수정합니다.

https://github.com/aws-actions
aws-actions를 사용합니다.
ECR에 저장하는 도커 이미지는 최신 5개만으로 유지합니다.
EC2 환경에서는 현재 구동 중인 도커 이미지만을 남깁니다.

How To Test

  • pnpm build 시 성공해야 합니다.
  • 배포에 성공해야 합니다.

@miro-ring
Copy link
Contributor Author

Copy link
Member

@wonjin-dev wonjin-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Member

@dmswl98 dmswl98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당

@miro-ring miro-ring merged commit 699e543 into main Jan 12, 2024
@miro-ring miro-ring deleted the feature/BAR-140 branch January 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants