[Feature/BAR-165] 끄적이는 레이아웃 작성 & 데이터 구조화 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonjin-dev
force-pushed
the
feature/BAR-165
branch
from
c6f6054 to
834bbd1
Compare
wonjin-dev
force-pushed
the
feature/BAR-165
branch
from
4fa8677 to
6f8dc6a
Compare
dmswl98
reviewed
Jan 15, 2024
Comment on lines
18
to
25
| export const value = style({ | ||
| marginBottom: '16px', | ||
| color: COLORS['Grey/900'], | ||
| fontSize: '15px', | ||
| fontWeight: '400', | ||
| lineHeight: '24px', | ||
| letterSpacing: '-0.2px', | ||
| }); |
There was a problem hiding this comment.
export const content = style([
sprinkles({ typography: '15/Body/Regular' }),
{
...
},
]);로 사용하면 될 것 같습니다!
Comment on lines
18
to
24
| export const dateLabelWrapper = style({ | ||
| display: 'flex', | ||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
| marginTop: '12px', | ||
| marginBottom: '24px', | ||
| }); |
There was a problem hiding this comment.
Suggested change
| export const dateLabelWrapper = style({ | |
| display: 'flex', | |
| justifyContent: 'center', | |
| alignItems: 'center', | |
| marginTop: '12px', | |
| marginBottom: '24px', | |
| }); | |
| export const dateLabelWrapper = style([ | |
| utils.flexCenter, | |
| { | |
| marginTop: '12px', | |
| marginBottom: '24px', | |
| } | |
| ]); |
이렇게 사용하셔도 됩니다!
Comment on lines
26
to
33
| export const dateLabel = style({ | ||
| padding: '6px 28px', | ||
| display: 'flex', | ||
| justifyContent: 'center', | ||
| alignItems: 'center', | ||
| border: `1px solid ${COLORS['Grey/200']}`, | ||
| borderRadius: '100px', | ||
| }); |
src/domain/Write/History/index.tsx
Outdated
|
|
||
| import { type WriteHisotry } from '../types'; | ||
| import WriteHistoryCard from './components/Card'; | ||
| import * as style from './index.css'; |
There was a problem hiding this comment.
Suggested change
| import * as style from './index.css'; | |
| import * as styles from './style.css'; |
엇 이렇게 작성하는 걸로 통일했던 거 같아요.
Comment on lines
12
to
16
| export const contentWrapper = style({ | ||
| display: 'grid', | ||
| gridTemplateColumns: '1fr 1fr 1fr', | ||
| gap: '16px', | ||
| }); |
There was a problem hiding this comment.
위 레이아웃을 위해 grid-auto-flow 속성도 넣어야 할 것 같습니당
miro-ring
reviewed
Jan 16, 2024
| @@ -20,7 +20,7 @@ | |||
| "@assets/*": ["./src/assets/*"], | |||
| "@components/*": ["./src/components/*"], | |||
| "@constants/*": ["./src/constants/*"], | |||
| "@feature/*": ["./src/feature/*"], | |||
| "@domain/*": ["./src/domain/*"], | |||
There was a problem hiding this comment.
@wonjin-dev
요건 어떤 이유로 수정된걸까요?
There was a problem hiding this comment.
domain 하위에 각각의 feature 폴더들이 들어가야하는건지? 궁금했습니다.
|
@dongkyun-dev @dmswl98 추가 커밋이 있어서 노티드립니다~ 리뷰 주시면, API 연결 + 페이징 처리하면서 함께 반영할게요 !
|
dmswl98
reviewed
Jan 24, 2024
Comment on lines
+16
to
+33
| const parser = (arr: Write[]): Write[][] => { | ||
| let queue1: Write[] = []; | ||
| let queue2: Write[] = []; | ||
| let queue3: Write[] = []; | ||
|
|
||
| arr.forEach((history, i) => { | ||
| const extra = i % 3; | ||
| if (extra === 0) { | ||
| queue1.push(history); | ||
| } else if (extra === 1) { | ||
| queue2.push(history); | ||
| } else { | ||
| queue3.push(history); | ||
| } | ||
| }); | ||
|
|
||
| return [queue1, queue2, queue3]; | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Reviewers
margin: 0 auto&max-widthHow To Test
/write페이지에서 확인 가능