slidesToSlide-To accept 0 as truthy value #412
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using react-multi-carousel for our app and we are hit with below limitation / issue.
Given: Some of the slides in our carousel have more than 1 buttons on it.
When: those slides are focused, 1st button get focus.
Then: i press right
Expected: Focus should move to next button on the same slide.
Actual: Focus moving to next slide
I found that if slidesToSlide can be dynamically set to 0 when such slides are focused, i will be able to block the slide transition until the focus is on last button.
In this PR, i have made slidesToSlide to be defaulted to 1, only of responsive.slidesToSlide is undefined, so that 0 is accepted as a truthy value.