diff --git a/bxt-strafe/src/steps.rs b/bxt-strafe/src/steps.rs index 9143953a..4db0450b 100644 --- a/bxt-strafe/src/steps.rs +++ b/bxt-strafe/src/steps.rs @@ -793,10 +793,7 @@ impl Step for LeaveGround { .0 .simulate(tracer, parameters, frame_bulk, state.clone(), input); - let action = match frame_bulk.auto_actions.leave_ground_action { - Some(x) => x, - None => return do_nothing, - }; + let Some(action) = frame_bulk.auto_actions.leave_ground_action else { return do_nothing }; if action.times != Times::UnlimitedWithinFrameBulk { return do_nothing; diff --git a/src/hooks/bxt.rs b/src/hooks/bxt.rs index 1c724598..4f482266 100644 --- a/src/hooks/bxt.rs +++ b/src/hooks/bxt.rs @@ -36,12 +36,9 @@ fn open_library() -> Option { #[instrument(name = "bxt::find_pointers", skip_all)] pub unsafe fn find_pointers(marker: MainThreadMarker) { - let library = match open_library() { - Some(library) => library, - None => { - debug!("could not find Bunnymod XT"); - return; - } + let Some(library) = open_library() else { + debug!("could not find Bunnymod XT"); + return; }; for pointer in POINTERS { diff --git a/src/hooks/opengl32.rs b/src/hooks/opengl32.rs index 4285db6f..23f62914 100644 --- a/src/hooks/opengl32.rs +++ b/src/hooks/opengl32.rs @@ -31,12 +31,9 @@ fn open_library() -> Option { /// stale. #[instrument(name = "opengl32::find_pointers", skip_all)] pub unsafe fn find_pointers(marker: MainThreadMarker) { - let library = match open_library() { - Some(library) => library, - None => { - warn!("error loading opengl32.dll"); - return; - } + let Some(library) = open_library() else { + warn!("error loading opengl32.dll"); + return; }; for pointer in POINTERS { diff --git a/src/hooks/sdl.rs b/src/hooks/sdl.rs index 07471f65..d6667e80 100644 --- a/src/hooks/sdl.rs +++ b/src/hooks/sdl.rs @@ -92,12 +92,9 @@ fn open_library() -> Option { /// [`reset_pointers()`] must be called before SDL is unloaded so the pointers don't go stale. #[instrument(name = "sdl::find_pointers", skip_all)] pub unsafe fn find_pointers(marker: MainThreadMarker) { - let library = match open_library() { - Some(library) => library, - None => { - warn!("error loading SDL2"); - return; - } + let Some(library) = open_library() else { + warn!("error loading SDL2"); + return; }; for pointer in POINTERS { diff --git a/src/modules/capture/mod.rs b/src/modules/capture/mod.rs index afb8ba37..c8c59625 100644 --- a/src/modules/capture/mod.rs +++ b/src/modules/capture/mod.rs @@ -436,10 +436,7 @@ pub unsafe fn capture_sound(marker: MainThreadMarker, mode: SoundCaptureMode) { pub unsafe fn on_s_transfer_stereo_16(marker: MainThreadMarker, end: i32) { let mut state = STATE.borrow_mut(marker); - let recorder = match *state { - State::Recording(ref mut recorder) => recorder, - _ => return, - }; + let State::Recording(ref mut recorder) = *state else { return }; let painted_time = *engine::paintedtime.get(marker); let paint_buffer = &*engine::paintbuffer.get(marker); @@ -466,10 +463,7 @@ pub unsafe fn on_s_transfer_stereo_16(marker: MainThreadMarker, end: i32) { pub unsafe fn on_host_filter_time(marker: MainThreadMarker) -> bool { let mut state = STATE.borrow_mut(marker); - let recorder = match *state { - State::Recording(ref mut recorder) => recorder, - _ => return false, - }; + let State::Recording(ref mut recorder) = *state else { return false }; if (*engine::cls_demos.get(marker)).demoplayback == 0 { return false; @@ -517,10 +511,7 @@ pub fn prevent_toggle_console(marker: MainThreadMarker) -> bool { pub unsafe fn time_passed(marker: MainThreadMarker) { let mut state = STATE.borrow_mut(marker); - let recorder = match *state { - State::Recording(ref mut recorder) => recorder, - _ => return, - }; + let State::Recording(ref mut recorder) = *state else { return }; // Accumulate time for the last frame. let time = *engine::host_frametime.get(marker); diff --git a/src/modules/hud_scale.rs b/src/modules/hud_scale.rs index 248b8307..2c12a5bc 100644 --- a/src/modules/hud_scale.rs +++ b/src/modules/hud_scale.rs @@ -62,12 +62,7 @@ pub unsafe fn with_scaled_projection_matrix( marker: MainThreadMarker, f: impl FnOnce() -> T, ) -> T { - let scale = match scale(marker) { - Some(scale) => scale, - None => { - return f(); - } - }; + let Some(scale) = scale(marker) else { return f() }; { let (width, height) = engine::get_resolution(marker); diff --git a/src/modules/tas_optimizer/mod.rs b/src/modules/tas_optimizer/mod.rs index 15219b5c..583ac3c4 100644 --- a/src/modules/tas_optimizer/mod.rs +++ b/src/modules/tas_optimizer/mod.rs @@ -317,15 +317,9 @@ fn optim_init(marker: MainThreadMarker, path: PathBuf, first_frame: usize) { // TODO: this function must be marked as unsafe. Getting the player data should be safe in a // console command callback, however by being safe, this function can be called from anywhere // else in the code. - let player = match unsafe { player_data(marker) } { - Some(x) => x, - None => { - con_print( - marker, - "Cannot enable the TAS optimizer outside of gameplay.\n", - ); - return; - } + let Some(player) = (unsafe { player_data(marker) }) else { + con_print(marker, "Cannot enable the TAS optimizer outside of gameplay.\n"); + return; }; // TODO: get current parameters. @@ -742,10 +736,7 @@ fn optim_simulation_done(_marker: MainThreadMarker) { } pub unsafe fn maybe_receive_messages_from_remote_server(marker: MainThreadMarker) { - let cls = match engine::cls.get_opt(marker) { - Some(x) => x, - None => return, - }; + let Some(cls) = engine::cls.get_opt(marker) else { return }; let client_state = (*cls).state; if client_state != 1 && client_state != 5 { diff --git a/src/modules/tas_optimizer/remote.rs b/src/modules/tas_optimizer/remote.rs index 0f49efc4..2a13c5e1 100644 --- a/src/modules/tas_optimizer/remote.rs +++ b/src/modules/tas_optimizer/remote.rs @@ -527,15 +527,9 @@ pub fn receive_new_hltas_to_simulate() -> Option { pub fn on_frame_simulated(get_frame_data: impl FnOnce() -> Frame) { let mut state = STATE.lock().unwrap(); - let server = match state.remote_server() { - Some(x) => x, - None => return, - }; + let Some(server) = state.remote_server() else { return }; - let pending_frames = match &mut server.simulation_state { - SimulationState::Recording(frames) => frames, - _ => return, - }; + let SimulationState::Recording(pending_frames) = &mut server.simulation_state else { return }; let frame = get_frame_data(); @@ -544,10 +538,7 @@ pub fn on_frame_simulated(get_frame_data: impl FnOnce() -> Frame) { pub fn send_simulation_result_to_server() { let mut state = STATE.lock().unwrap(); - let server = match state.remote_server() { - Some(x) => x, - None => return, - }; + let Some(server) = state.remote_server() else { return }; // Send empty frames if needed to avoid softlocks in unforeseen situations. let pending_frames = server.simulation_state.take_frames().unwrap_or_default(); @@ -560,10 +551,7 @@ pub fn send_simulation_result_to_server() { pub fn start_recording_frames() { let mut state = STATE.lock().unwrap(); - let server = match state.remote_server() { - Some(x) => x, - None => return, - }; + let Some(server) = state.remote_server() else { return }; if server.simulation_state.is_waiting_to_start() { server.simulation_state = SimulationState::Recording(Vec::new());