Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bxt_cap] Game freezes until moov atom flag is moved to the beginning of the file #14

Open
chinese-soup opened this issue Jul 31, 2021 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@chinese-soup
Copy link
Contributor

chinese-soup commented Jul 31, 2021

Game freezes upon finishing capturing until ffmpeg finishes:
[mp4 @ 0x55602df8f400] Starting second pass: moving the moov atom to the beginning of the file

Is there a way for it to not freeze the game while still preserving the faststart flag?

@YaLTeR
Copy link
Owner

YaLTeR commented Jul 31, 2021

While there should be nothing preventing bxt-rs from detaching the FFmpeg subprocess once we're done pumping data into it, the freeze was left semi-intentionally.

  1. It gives a clear indication of when the output mp4 is ready to use.
  2. It lets bxt-rs collect the final FFmpeg output (possibly containing errors) and display it without causing confusion with potentially the next capture running.
  3. It prevents a class of errors when you bxt_cap_stop then bxt_cap_start before the previous one finishes.

That's not to say I like the freeze, maybe some alternative solution like freezing on bxt_cap_start till the previous capture is done can work.

@YaLTeR YaLTeR added enhancement New feature or request question Further information is requested labels Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants