Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the effect of state encoding indentity connection in dynamics network #35

Open
puyuan1996 opened this issue Nov 6, 2022 · 1 comment

Comments

@puyuan1996
Copy link

puyuan1996 commented Nov 6, 2022

Thanks for your open-sourced code very much.

I'm a little confused about the reason for the identity connection of state encoding in DynamicsNetwork in model.py:

Why do we add this state encoding identity connection, rather than using action encoding, and what is its empirical impact on atari results?

Looking forward to your reply!

@YeWR
Copy link
Owner

YeWR commented Nov 23, 2022

Thank you for your comments.

The identity connection here follows the same architecture of resnets. The residual part provides richer and better gradients when the network is deep. Considering the dynamics network unrolls 5 steps recurrently, the gradient flow of the final unroll can be much deeper (over 10 layers). Consequently, we add the identity connection here.

As for empirical results, we find that such an identity connection shapes a better reward model. We collect some datasets and try to predict the reward through supervised learning for these data. We find that the model with the identity connection has a lower test error of the reward prediction.

Hope this address your concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants