Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope of automated Github CI checks for pull requests #327

Open
Muppeq opened this issue May 7, 2024 · 1 comment
Open

scope of automated Github CI checks for pull requests #327

Muppeq opened this issue May 7, 2024 · 1 comment
Assignees

Comments

@Muppeq
Copy link
Contributor

Muppeq commented May 7, 2024

If there was a json key change in the en.json file all translations are failing their checks as they have (now) unknown keys.
I avoid messing around in other language json files that I can't understand, but that would now be needed to get new translations past the automated Github checks.

I suggest changing the check after PR creation to only include the json files changed in this PR, so that there is no need to delete lines in or edit other languages files just to get your own changes passing.

Of course this leaves language files with now unknown keys in the repository, but that is the same situation as after the key change and before merging in a PR. As I understand it resonite just ignores these lines.

@ProbablePrime
Copy link
Member

I agree, ill work on this as soon as I can.

@ProbablePrime ProbablePrime self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants