Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_missing_properties not honored when using model constructor #290

Open
vincer opened this issue Jul 24, 2018 · 1 comment
Open

include_missing_properties not honored when using model constructor #290

vincer opened this issue Jul 24, 2018 · 1 comment

Comments

@vincer
Copy link

vincer commented Jul 24, 2018

https://github.com/Yelp/bravado-core/blob/master/bravado_core/model.py#L304

It seems like there should be a config lookup there, like in Model._from_dict?

My workaround has been to use _unmarshal which works correctly.

@sjaensch
Copy link
Contributor

include_missing_properties is intended to configure the way the models look and behave when being returned as part of a deserialized response.

That said, I don't see a reason why we couldn't add the same behavior to the __init__ method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants