Skip to content
This repository has been archived by the owner on Oct 5, 2019. It is now read-only.

Split osxcollector.py into several modules #121

Open
jjsendor opened this issue Dec 17, 2015 · 2 comments
Open

Split osxcollector.py into several modules #121

jjsendor opened this issue Dec 17, 2015 · 2 comments

Comments

@jjsendor
Copy link
Contributor

osxcollector.py grew over time and right now is one big unmaintainable chunk of code.
The initial motivation to keep it in one file to make it easy to run seems to be a bit too tight as the changes to the core file are not made that often. It should be possible to release it as an executable or via tools like pip in order to make it easy to install and run.

Code separation into modules would make it easier to maintain the code base and avoid duplication with the other projects (e.g. for things like DictUtils that are also in the OSXCollector Output Filters repository).

@ktneely
Copy link

ktneely commented Dec 30, 2015

Is it possible to keep the collection aspect as a single script? I'm sure it is becoming unwieldy, however, I wouldn't underestimate the usefulness of the collection being a single script that can be run on any standard Mac. As it stands, I can (and have at multiple companies) written a simple procedure for the helpdesk team to follow when they encounter something. These are people who do not know what pip or forensic artifacts are, but they are the initial touchpoint with the users when a detection occurs.

@jjsendor
Copy link
Contributor Author

@ktneely this is a useful feedback! I have created that issue also to gather a feedback from people who use OSXCollector.

I am not sure if we will ever go forward with that change, though some of the recent contributions would actually be easier if we keep the design modular and allow external dependencies, e.g. #127 could have been just an import of the original project available at https://github.com/secretsquirrel/kyphosis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants