Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the installation instruction and make latest builds available in release #51

Open
johnyoonh opened this issue Apr 2, 2019 · 3 comments

Comments

@johnyoonh
Copy link

The building the library requires following steps:

  • Visual Studio Build Tools 2017
  • Installing dotnet 4.6.1 developer SDK
  • NuGet package manager (from Individual Components in the Visual Studio Build Tools)
  • .NET core build tools (optional 2.0 must be selected)
  • C:\Windows\Microsoft.NET\Framework\v4.0.30319\ needs to be added to PATH

nuget.exe restore ..\YAPA.sln must be ran again in a new shell preferrably to reload the PATH.

And possibly modifying Build.cmd to set path

call "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\VsDevCmd.bat"

Also the build instruction needs to be updated:
#46

@floatas
Copy link
Contributor

floatas commented Apr 2, 2019

Hey, Entire structure and build process is to complex. I will spend some time this week to clean all issues and change structure.

@AlexP11223
Copy link
Contributor

Looks like it's still kind of complex, and now it's not possible to create installer if there is no Build/Release/RELEASES file.

@floatas
Copy link
Contributor

floatas commented Apr 8, 2019

Good catch, looks like you need to create empty Build/Release folder.

  1. Run Build.cmd
  2. Run CreateNuget.ps1 (make sure Build/Release folder exists).
    All necessary files will be downloaded, and full installer with delta will be created.

As for dependencies, .net core 3 will support WPF, need to look more into this. With .net core 3 we might remove most if not all dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants