diff --git a/CHANGELOG.md b/CHANGELOG.md index f527e281..ac83ad4a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ We will follow [Semantic Versioning](http://semver.org/). ## UNRELEASED ### Fixed +- Prevent undefined array key warning within `LinkingSuggestionsService` - Missing label of the tx_yoastseo_prominent_word table - Removed exclude=true from tx_yoastseo_prominent_word fields, table already has hideTable - Use `websiteTitle` of site configuration within snippet preview, previously this was only taken from site languages instead of the site itself diff --git a/Classes/Service/LinkingSuggestionsService.php b/Classes/Service/LinkingSuggestionsService.php index 8a8b0f9e..ad278175 100644 --- a/Classes/Service/LinkingSuggestionsService.php +++ b/Classes/Service/LinkingSuggestionsService.php @@ -253,10 +253,10 @@ protected function groupWordsByRecord(array $candidateWords): array { $candidateWordsByRecords = []; foreach ($candidateWords as $candidateWord) { - $recordKey = $candidateWord['uid_foreign'] . '-' . $candidateWord['tablenames']; - if (!array_key_exists('weight', $candidateWord) || !array_key_exists('df', $candidateWord)) { + if (!isset($candidateWord['weight'], $candidateWord['df'])) { continue; } + $recordKey = $candidateWord['uid_foreign'] . '-' . $candidateWord['tablenames']; $candidateWordsByRecords[$recordKey][$candidateWord['stem']] = [ 'weight' => (int)$candidateWord['weight'], 'df' => (int)$candidateWord['df'] @@ -348,7 +348,7 @@ protected function linkRecords(array $scores, array $currentLinks): array 'recordType' => $this->getRecordType($table), 'id' => $uid, 'table' => $table, - 'cornerstone' => array_key_exists('tx_yoastseo_cornerstone', $data) ? (int)$data['tx_yoastseo_cornerstone'] : 0, + 'cornerstone' => (int)($data['tx_yoastseo_cornerstone'] ?? 0), 'score' => $score, 'active' => isset($currentLinks[$record]) ];