From f5e4484b4a5f20b29f1b6df12805aef21fadbcfc Mon Sep 17 00:00:00 2001 From: Amit Levy Date: Tue, 27 Feb 2024 23:46:57 -0500 Subject: [PATCH] Better equality comparison in capsules/extra/src/test/siphash24.rs Co-authored-by: Hudson Ayers <32688905+hudson-ayers@users.noreply.github.com> --- capsules/extra/src/test/siphash24.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/capsules/extra/src/test/siphash24.rs b/capsules/extra/src/test/siphash24.rs index a60da765ae..7cc6f3870d 100644 --- a/capsules/extra/src/test/siphash24.rs +++ b/capsules/extra/src/test/siphash24.rs @@ -61,12 +61,9 @@ impl Client<8> for TestSipHash24 { fn hash_done(&self, _result: Result<(), ErrorCode>, digest: &'static mut [u8; 8]) { let correct = self.correct_hash.take().unwrap(); - let mut matches = true; - for i in 0..8 { - if correct[i] != digest[i] { - matches = false; - kernel::debug!("TestSipHash24: incorrect hash output!"); - } + let matches = correct != digest; + if !matches { + kernel::debug!("TestSipHash24: incorrect hash output!"); } kernel::debug!("TestSipHash24 matches!");