Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #13054 #3

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Resolve issue #13054 #3

merged 7 commits into from
Oct 25, 2024

Conversation

Shibui-Li-1998
Copy link
Collaborator

Fixes TEAMMATES#13054

Outline of Solution

1. Code Change Location:

The following files were updated to implement the feature:

2. Details of the Changes:

  • Added a text input field above the dropdown student list to facilitate search.
  • Implemented logic to allow users to search for students by entering substrings of their names.
  • Manually tested the new feature by inputting various substrings to ensure accurate search functionality.
  • Added new test cases to cover the updated functionality.

3. Demonstration:

Before:
Before

After:
After1
After2

@Shibui-Li-1998 Shibui-Li-1998 added the good first issue Good for newcomers label Oct 25, 2024
@Shibui-Li-1998 Shibui-Li-1998 self-assigned this Oct 25, 2024
Copy link

Hi @Shibui-Li-1998, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@Shibui-Li-1998
Copy link
Collaborator Author

I have checked the codes and there is no conflicts.

@Shibui-Li-1998 Shibui-Li-1998 merged commit 97c972e into master Oct 25, 2024
3 checks passed
@Yokyeee1114
Copy link
Owner

I have checked the code and it is ok to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make substrings of the name in dropdown selections of recipient to be searchable
4 participants