Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection of skaffold dev [not run] mode fails with Skaffold 1.13+ #19

Open
solsson opened this issue Sep 3, 2020 · 0 comments
Open

Detection of skaffold dev [not run] mode fails with Skaffold 1.13+ #19

solsson opened this issue Sep 3, 2020 · 0 comments

Comments

@solsson
Copy link
Contributor

solsson commented Sep 3, 2020

kubernetes-assert/runtime-nodejs/kustomize/scrapeable-deployment.yaml

Line 45 in 0a337dc

fieldPath: metadata.labels['skaffold.dev/tail']
doesn't work anymore.

The labels I see on a new skaffold dev deployment is:

              app.kubernetes.io/managed-by=skaffold
              skaffold.dev/run-id=c999a4c5-db64-4f1c-9fe5-89f1b68b93fc
solsson added a commit that referenced this issue May 11, 2021
@solsson
As #19 documents this env no longer works
b50c145 
so let's look for alternative appoaches, starting with #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solsson