Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formally document thread safety #1388

Open
Ravenslofty opened this issue Oct 25, 2024 · 0 comments
Open

Formally document thread safety #1388

Ravenslofty opened this issue Oct 25, 2024 · 0 comments

Comments

@Ravenslofty
Copy link
Collaborator

We have a bunch of implied threading constraints throughout nextpnr, and these are hindering performance scaling by requiring working around them through abstraction layers - router2 for example.

We can already group certain APIs as things we know are independent - the logging API and the pip/bel manipulation API are separate, but within them they are not thread-safe.

It would be useful to describe these within the architecture API docs; especially for performance-critical APIs like pip/bel manipulation, it would be useful if the API guaranteed that pips that are physically separate (are not connected by a wire) can be modified concurrently. (This would implicitly forbid dynamically allocated data structures that are not protected by a lock)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant