Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glob dependency to >9.0.0 #605

Open
joehan opened this issue Jun 3, 2024 · 3 comments
Open

Update glob dependency to >9.0.0 #605

joehan opened this issue Jun 3, 2024 · 3 comments

Comments

@joehan
Copy link

joehan commented Jun 3, 2024

This package currently uses glob<v9, which transitively depends on inflight, which is deprecated due to leaking memory.

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.

npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

To fix this, just update glob to >9.0.0

@robogeek
Copy link

robogeek commented Jun 27, 2024

Exactly. In my case I get the same warning as the OP. The offending reference to glob is shown here:

$ npm ls glob
[email protected] /home/david/Projects/Evoke-mac/esx-core/server
├─┬ [email protected]
│ └─┬ @anttiviljami/[email protected]
│   └── [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ @mark.probst/[email protected]
│     └── [email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected] deduped

I also notice the offending dependency on inflight is also this same module:

$ npm ls inflight
[email protected] /home/david/Projects/Evoke-mac/esx-core/server
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ @mark.probst/[email protected]
      └─┬ [email protected]
        └── [email protected]

For inflight there is not a quick fix because the suggested route is to convert to lru-cache

@robogeek
Copy link

For the inflight issue see: #608

@Artoria2e5
Copy link

Artoria2e5 commented Jul 12, 2024

Do the glob people have any information on what actually changed to require a major semver bump? Something inconsequential (to this project) like a Nodejs minimum version change, or something that requires code change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants