Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Zealand flag seems broken #62

Open
2 of 3 tasks
Titou325 opened this issue Oct 5, 2021 · 5 comments
Open
2 of 3 tasks

New Zealand flag seems broken #62

Titou325 opened this issue Oct 5, 2021 · 5 comments

Comments

@Titou325
Copy link

Titou325 commented Oct 5, 2021

Please check all that apply

  • visual bug
  • functional bug
  • able to consistently reproduce

Expected Behavior

The New Zealand flag should have a red cross in its top left corner.

image

Current Behavior

The New Zealand flag is missing its red cross.

image

This is also the case in this repository

Possible Solution

Add the red cross.

Thanks a lot for this package!

@daoneandonly
Copy link
Contributor

Seems to me there is a masking issue with certain flags. I'll collect his and related issues here in as a single issue.

@daoneandonly
Copy link
Contributor

daoneandonly commented Jul 20, 2022

As with #72 , the masking within some flag SVG seem to cause some visual bugs and potentially breaking bugs within react-native.

Found in Flags

  • NZ
  • CI

If you have found this only appear in certain sizes, feel free to share any of these insights.

@SimpleCreations
Copy link

@daoneandonly
The same issue can also be found in:

  • HR
  • KR

@DCzajkowski
Copy link

Croatian (HR) flag as mentioned by @SimpleCreations looks different on the landing page and different in the index. Both seem to have masking issues and scaling is wrong.

Tested on mobile Safari and iOS 16.0.3 webview

7B7E5ED4-CD3F-4D1D-8D47-92B31C860BC6
06ACE9DF-BB3D-4F14-AA19-F0C6DB90EACD

@kylegordy
Copy link

I've been working from the Figma Flag Pack, and these render bugs don't appear there from what I can tell. The New Zealand flag is how we stumbled upon this issue too.

Is there something in the build step, like a file size optimizer, that might be causing these render bugs? I've had issues like that happen before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants