Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No flag for Algeria. #91

Open
hasnatfahim12 opened this issue Apr 10, 2023 · 5 comments
Open

No flag for Algeria. #91

hasnatfahim12 opened this issue Apr 10, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@hasnatfahim12
Copy link

There seems to be no flag for the country Algeria. Algeria is the biggest country in Africa and the 10th biggest overall (by area). So Algeria should have a flag.

I believe it would benefit everyone using this and specially those who are creating product for the African continent.

@areeb111
Copy link

+1
I would suggest to add it please.

@zoeyfrisart
Copy link
Member

Hey, Thank you for creating this issue. The flag of Algeria is actually in Flagpack (https://github.com/Yummygum/flagpack-core/blob/main/svg/l/DZ.svg). I checked, and I see it is not in our documentation. I have not tested whether you can use the flag in the codebase, but I have passed this issue forward to the team.

Appologies for the delay in Response, I missed this issue in my Inbox until @areeb111 Responded. I hope to get back to you by the end of the week.

@zoeyfrisart zoeyfrisart added the bug Something isn't working label May 16, 2023
@areeb111
Copy link

areeb111 commented May 17, 2023

Thank you @zoeyfrisart , Actually i tried to use that in vue-flagpack with no chance,
I believe it's missing here too countryCodeList.ts and types as well

@zoeyfrisart
Copy link
Member

zoeyfrisart commented May 17, 2023

In that case it's most likely missing from the sheet we use to generate the types and exports, I hope to look at this and release a fix sometime in the upcoming weeks.

Edit, it appears to be in the file, I'll have to do some further investigating

@flpalves
Copy link

In the file "src/countryCodeList.ts" there is no information about Algeria.

Would adding this file solve the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants