Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminated build warnings #60

Closed
wants to merge 1 commit into from
Closed

Eliminated build warnings #60

wants to merge 1 commit into from

Commits on Sep 6, 2024

  1. Split fluid_synth_set_reverb and fluid_synth_set_chorus calls into se… 

    …parate per-parameter calls in music_fluidsynth_mididevice.cpp. Changed calls to fluid_synth_set_reverb_on and fluid_synth_set_chorus_on to use fluid_synth_reverb_on and fluid_synth_chorus_on.

Suppressed warnings about unused fread return values in music_timidity_mididevice.cpp, music_timiditypp_mididevice.cpp and instrum_dls.cpp.
Corrected indentation in itread.c, readmod.c and readxm.c.
Inlined the functionality of fluid_player_update_tempo inside fluid_player_set_bpm, as the former is deprecated and could be removed in a future version.
Corrected Ym2612_Nuked_Emu::reset in Ym2612_Nuked.cpp to only call OPN2_Reset on chip_r when chip_r is _not_ NULL, instead of only when it is.
Marked case ATTACK and case DECAY in envelope generation in OPL3.cpp as fallthrough to case DECAY and case SUSTAIN respectively.
    @logiclrd
    logiclrd committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3762a21 View commit details
    Browse the repository at this point in the history