Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Require zendframework/zendframework as dev dependency #77

Closed

Conversation

localheinz
Copy link
Contributor

This PR

  • adds zendframework/zendframework as a development dependency, as the previous .travis.yml suggested it is
  • updates composer.json to allow autoloading of classes in the ZfcBaseTest namespace in development
  • extracts a script from the previously existing ZfcBaseTest\Bootstrap class
  • skips instantiation of an autoloader in favour of autoloading with Composer
  • updates .travis.yml to actually install dependencies with Composer

Fixes #75.

- skip cloning [email protected]:zendframework/zf2.git into test directory
- specify configuration file for phpunit
@localheinz localheinz force-pushed the bugfix/zf2-dev-dependency branch 6 times, most recently from 124ab3a to 3f89b3c Compare November 22, 2014 14:26
@adamlundrigan adamlundrigan mentioned this pull request Jan 15, 2015
@localheinz localheinz closed this Mar 6, 2020
@localheinz localheinz deleted the bugfix/zf2-dev-dependency branch March 6, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Shouldn't ZF2 be a dependency?
1 participant